Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pitivi: fix build #96948

Merged
merged 2 commits into from Sep 2, 2020
Merged

pitivi: fix build #96948

merged 2 commits into from Sep 2, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 2, 2020

Motivation for this change

The latest version is not compatible with Python 3.8, let's cherry-pick some patches from master.

Also pre-prepare for incoming release of GStreamer 1.18 and clean it up a bit.

Fixes: #96914

cc @davidak

Did not test it other than by building and starting it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
pitivi: clean up
34c2ad1 
* format with nixpkgs-fmt
* use pkg-config instead of pkgconfig alias
* reorder attributes
* move version inside the mkDerivation
@jtojnar
pitivi: Fix build
2c152ee 
The latest version is not compatible with Python 3.8,
let's cherry-pick some patches from master.

Also pre-prepare for incoming release of GStreamer 1.18.
@jtojnar jtojnar marked this pull request as ready for review September 2, 2020 05:27
davidak
davidak approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
works

i have thrown in some videos and rendered a short test video. no problems

@jtojnar jtojnar merged commit dff0034 into NixOS:master Sep 2, 2020
@jtojnar jtojnar deleted the fix-pitivi branch September 2, 2020 19:25
@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 2, 2020

Thanks for testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pitivi build fails
2 participants
@jtojnar @davidak