NFC: performance improvements #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Sep 1, 2020
src/groupmesh.cpp
Outdated
| @@ -149,7 +149,7 @@ void Group::GenerateForStepAndRepeat(T *steps, T *outs, Group::CombineAs forWhat | |||
| std::vector<T> *scratch = &workA; | |||
| // do the boolean operations | |||
| while(n > 1) { | |||
| #pragma omp parallel for | |||
| //#pragma omp parallel for | |||
There was a problem hiding this comment.
Should this be commented?
There was a problem hiding this comment.
It should probably be removed. Running that loop in parallel does work, but it ends up giving only 1 thread to each boolean operation which slows them down.
|
Address Sanitizer fails, probably an issue in SSurface::AddExactIntersectionCurve(). I'll try pulling the first commit into a separate PR, that one is simple enough it should pass. |
|
Closing this, as it's been split into two separate PRs - one works, but the "simple" one still fails ASAN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit changes the order of booleans in repeat-groups. This reduces the average time for the booleans by combining equal size pieces. It also does the transforms in parallel when build with OMP.
Second commit brings OpenMP to the remaining time-consuming part of boolean operations.