Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timewarrior: 1.3.0 -> 1.4.2 #96962

Merged
merged 1 commit into from Sep 5, 2020
Merged

timewarrior: 1.3.0 -> 1.4.2 #96962

merged 1 commit into from Sep 5, 2020

Conversation

hoxu
Copy link
Contributor

@hoxu hoxu commented Sep 2, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hoxu
Copy link
Contributor Author

hoxu commented Sep 2, 2020

Ping @matthiasbeyer!

matthiasbeyer
matthiasbeyer reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@ofborg ofborg bot requested a review from mrVanDalo September 2, 2020 16:38
mrVanDalo
mrVanDalo approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@mrVanDalo mrVanDalo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using nix-review

  • create timer
  • stop timer
  • sum
  • lengthen/shorten
  • backwards compatibility ( timew 1.2.0 is capable of using the database created by timew 1.4.2)

@Lassulus Lassulus merged commit b4c262f into NixOS:master Sep 5, 2020
@hoxu hoxu deleted the timewarrior-1.4.2 branch September 6, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer left review comments

@mrVanDalo mrVanDalo mrVanDalo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hoxu @matthiasbeyer @mrVanDalo @Lassulus @Janik-Haag