Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-town: 7.3.0 → 7.4.0 #96944

Merged
merged 1 commit into from Sep 2, 2020
Merged

git-town: 7.3.0 → 7.4.0 #96944

merged 1 commit into from Sep 2, 2020

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Sep 2, 2020 •
edited

  • git-own --help suceeded

@blaggacao

This comment has been minimized.

Sign in to view
@ofborg ofborg bot requested a review from allonsy September 2, 2020 02:56
@blaggacao
Copy link
Contributor Author

Result of nixpkgs-review pr 96944 1

1 package built:
- git-town

@blaggacao

This comment has been minimized.

Sign in to view
@marvin-mk2 marvin-mk2 bot added the marvin label Sep 2, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Sep 2, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

marvin-mk2 bot commented Sep 2, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/287

@blaggacao
Copy link
Contributor Author

/status needs_reviewer

danieldk
danieldk approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96944 1

1 package built:
  • git-town

Tested binary: ✔️

Please keep and fill in the Things done template. Removing these makes reviewing harder.

@danieldk danieldk merged commit b268e89 into NixOS:master Sep 2, 2020
@blaggacao
Copy link
Contributor Author

@danieldk thanks for merging! ok will do. I thought it's ckearer this way, since most are redundand with nix-review post and the manual check (which I confirmed), but for the sake of structure, it might still be valuable. 👍

@blaggacao
Copy link
Contributor Author

@danieldk

Tested binary: ✔️

Did you do that manually in the report or is it a new version of nixpkgs-review?

@blaggacao blaggacao deleted the da-bump-gittown branch September 2, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@allonsy allonsy Awaiting requested review from allonsy

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blaggacao @nixos-discourse @danieldk