New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gstreamer: remove legacy version #96939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They have been broken and disabled for ages and now the dependencies are being removed.
It is insecure and broken. Follow NixOS#93398
it is insecure and broken
previously it was using the legacy one
jtojnar
force-pushed
the
drop-gst-010
branch
5 times, most recently
from
September 2, 2020 02:00
cccfbad
to
693557e
Compare
- use pkg-config instead of pkgconfig alias - use placeholders for cmakeFlags - do not skip build rpath - udev replacements no longer apply TheImagingSource/tiscamera@47d4fb2 There are some misplaced dependencies like gobject-introspection and orc that should probably go to nativeBuildInputs but upstream detects them incorrectly.
It has been abandoned for ages, insecure, and now finally broken.
jtojnar
force-pushed
the
drop-gst-010
branch
from
September 2, 2020 02:01
693557e
to
4a4e642
Compare
Lol, and hopefully we could actually have the gstreamer packages not under a weird attribute (eventually). Yay to this ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It has been abandoned and insecure for ages. Now it has finally broke so no one should complain.
Fixes: #39975
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)