Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strigi: drop #96937

Merged
merged 1 commit into from Sep 2, 2020
Merged

strigi: drop #96937

merged 1 commit into from Sep 2, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 2, 2020

Motivation for this change

It has not been used by KDE for many years and depends on umaintained libraries we want to drop (Qt4 and Gamin).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
strigi: drop
77293ba 
It has not been used by KDE for many years and depends on umaintained libraries we want to drop (Qt4 and Gamin).
@jtojnar jtojnar added this to In progress in Picking up garbage Sep 2, 2020
danieldk
danieldk reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add the attribute to aliases.nix, in case somebody still uses strigi?

@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 2, 2020

I doubt anybody is still using this. No desktop supports it any more.

@worldofpeace worldofpeace merged commit 31008a8 into NixOS:master Sep 2, 2020
Picking up garbage automation moved this from In progress to Done Sep 2, 2020
@jtojnar jtojnar deleted the drop-strigi branch September 2, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @danieldk @worldofpeace