Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: nodejs: Update override example to use overlays #96963

Merged
merged 1 commit into from Sep 4, 2020
Merged

doc: nodejs: Update override example to use overlays #96963

merged 1 commit into from Sep 4, 2020

Conversation

doronbehar
Copy link
Contributor

Also: Add links so it'll be easier to find the referred files.

Motivation for this change

It took me at least 15 minutes to understand what to do for #96961 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
doc: nodejs: Update override example to use overlays
c67bcd2 
Also: Add links so it'll be easier to find the referred files.
@rnhmjoj rnhmjoj merged commit 2b575c5 into NixOS:master Sep 4, 2020
@doronbehar doronbehar deleted the doc/nodejs branch March 2, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @rnhmjoj