Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtg: Run tests #96932

Merged
merged 1 commit into from Sep 3, 2020
Merged

gtg: Run tests #96932

merged 1 commit into from Sep 3, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Sep 1, 2020

Motivation for this change

This package comes with tests. Run them.

  • Running tests helps identify causes when things break in the public tree.
  • Running tests helps me more quickly detect problems in my local patched builds.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    No change: 993270144 → 993270144
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This adds

Running install tests
....................................................................................................
----------------------------------------------------------------------
Ran 100 tests in 0.125s

OK

to the build output.

@chkno chkno requested a review from oyren September 1, 2020 21:55
oyren
oyren approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@oyren oyren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests were completed, builds and runs. LGTM.

@ofborg ofborg bot requested a review from oyren September 1, 2020 22:54
oyren
oyren approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@oyren oyren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests were completed, builds and runs. LGTM. once again for the bot ;)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/214

@AndersonTorres AndersonTorres merged commit 59f5cbd into NixOS:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyren oyren oyren approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chkno @nixos-discourse @oyren @AndersonTorres