Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netbeans: 12.0 -> 12.1 #96931

Merged
merged 1 commit into from Sep 17, 2020
Merged

netbeans: 12.0 -> 12.1 #96931

merged 1 commit into from Sep 17, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Sep 1, 2020

Motivation for this change

Updated to latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
 asbachb@nixos  ~/dev/src/nix/nixpkgs/pkgs/applications/editors/netbeans   update-netbeans  nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
these paths will be fetched (0.03 MiB download, 0.13 MiB unpacked):
  /nix/store/hpsr5c2x5fjh1ad1wmlbnnqmdp8qckc4-nixpkgs-review-2.3.1
copying path '/nix/store/hpsr5c2x5fjh1ad1wmlbnnqmdp8qckc4-nixpkgs-review-2.3.1' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 48, done.
remote: Counting objects: 100% (48/48), done.
remote: Compressing objects: 100% (31/31), done.
remote: Total 55 (delta 32), reused 17 (delta 17), pack-reused 7
Unpacking objects: 100% (55/55), 71.37 KiB | 936.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   44d841f758d..fa50d74be3e  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-69027b0c95f1c6573171e96acfee14bd1e9a46e1-dirty/nixpkgs fa50d74be3e86a25a7da9598bd6a65d000cb4f3b
Preparing worktree (detached HEAD fa50d74be3e)
Updating files: 100% (22596/22596), done.
HEAD is now at fa50d74be3e Merge pull request #93802 from r-ryantm/auto-update/libraw
$ nix-env -f /home/asbachb/.cache/nixpkgs-review/rev-69027b0c95f1c6573171e96acfee14bd1e9a46e1-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asbachb
Copy link
Contributor Author

asbachb commented Sep 7, 2020

/cc @NeQuissimus

@Lassulus Lassulus merged commit 6bc5826 into NixOS:master Sep 17, 2020
@asbachb asbachb deleted the update-netbeans branch January 25, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants