Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limesurvey: 3.17.12+190823 -> 3.23.0+200813 #96926

Merged
merged 1 commit into from Sep 2, 2020
Merged

limesurvey: 3.17.12+190823 -> 3.23.0+200813 #96926

merged 1 commit into from Sep 2, 2020

Conversation

davidak
Copy link
Member

@davidak davidak commented Sep 1, 2020 •
edited

Motivation for this change

fixes #90870 at least 17 CVEs

does not solve #86087

cc maintainer @offlinehacker

Things done

i have created a minimal survey and participated. works

i haven't tested un update of existing installation. would be good

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker September 1, 2020 21:07
@aanderse
Copy link
Member

aanderse commented Sep 1, 2020

Bonus points is you add the test to passthru and push before we merge.

@davidak
limesurvey: 3.17.12+190823 -> 3.23.0+200813
de1c054 
fixes at least 17 CVEs
also adds test to package
@davidak
Copy link
Member Author

davidak commented Sep 2, 2020

@aanderse good idea!

@davidak
Copy link
Member Author

davidak commented Sep 2, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Sep 2, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@aanderse aanderse merged commit 259aaf6 into NixOS:master Sep 2, 2020
@aanderse
Copy link
Member

aanderse commented Sep 2, 2020

Sorry I was late to the party 🎉

@davidak davidak deleted the limesurvey-update branch September 2, 2020 16:03
@davidak
Copy link
Member Author

davidak commented Sep 2, 2020

@aanderse thanks. i was not sure if you have merge permission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 85: limesurvey-3.17.12+190823: 17 advisories [9.8]
2 participants
@davidak @aanderse