Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bloop: 1.4.3 -> 1.4.4 #96953

Merged
merged 1 commit into from Sep 5, 2020
Merged

bloop: 1.4.3 -> 1.4.4 #96953

merged 1 commit into from Sep 5, 2020

Conversation

JesusMtnez
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JesusMtnez
Copy link
Contributor Author

JesusMtnez commented Sep 2, 2020

@Tomahna I saw you are maintaining this pkg. I have tried to upgrade, but I haven't found the proper way to calculate the hashes for darwin and linux. Is there a special process for it?

Right now, I am replicating the installation process in a shell, but I am not obtaining the expected hash for Linux (I do not have a proper way to test it for MacOS).

nix-shell -p coursier
> wget https://github.com/scalacenter/bloop/releases/download/v1.4.4/bloop-coursier.json
> coursier install --install-dir out --install-platform x86_64-pc-linux --default-channels=true --channel bloop-coursier.json --only-prebuilt=true bloop
> sed -i '5,$ d' out/bloop
> nix-hash --type sha256 --flat --base32 out/bloop

But the result using the hash from that is giving me:

hash mismatch in fixed-output derivation '/nix/store/d46jblh435xy9r21vvn27j5xa29vr45b-bloop-coursier-1.4.4':
  wanted: sha256:0hggdqjx95bzc3s90aspcb89i51wz17cbn29jx9ndhm18x0ymja1
  got:    sha256:0hf0priy93zqba78a9nvbgl3mzwlc4jz43gz7cv2cdkj6x0lp0y1

@jonringer
Copy link
Contributor

there should be 5 hash changes, as it pulls down many different srcs

@JesusMtnez
Copy link
Contributor Author

I think I have finally found the problem. I was doing the hash for out/bloop instead of the hole out directory.

Using nix-hash --type sha256 --base32 out/ calculated the proper hash. I do not have an OSX machine to test though.

@jonringer
Copy link
Contributor

what i meant is that the other shell completions need to be bumped as well, otherwise they will fail

seems that the contents of the shell completion scripts didnt actually change

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/96953
1 package built:
bloop

@jonringer
Copy link
Contributor

@GrahamcOfBorg build bloop

@Tomahna
Copy link
Contributor

Tomahna commented Sep 5, 2020

Tested on nixos, LGTM.

@Lassulus Lassulus merged commit 3814d05 into NixOS:master Sep 5, 2020
@JesusMtnez JesusMtnez deleted the bloop branch November 2, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants