wireshark-*: pass in overridden libpcap in all-packages.nix #96950
Conversation
|
It seems the root issue is the bluez occasionally errors on build per #91011. As far as I can tell this is nothing specifically to do with wireshare itself. If bluez is to be removed as a dependency it doesn't really make sense to do that to the cli version for wireshark but not the QT version. Personally, given the 9 out of 1000 failure rate I don't think this is warrented. |
|
My build bluez always freezing. |
|
On servers are unlikely to used bluetooth. |
There was a problem hiding this comment.
As written in #91011, bluez seems a bit flaky in general. We shouldn't try to patch this around in other things consuming bluez, but fix it properly.
Please move the libpcap override to all-packages.nix (as you did), but keep with withBluez = stdenv.isLinux; as is.
You can then easily override wireshark-cli in your server overlay.
People might want to still have wireshark-cli with bluez support.
|
The commit message is still the old one (and we don't disable bluetooth anymore). Maybe
|
Izorkin
changed the title
|
Thanks, update. |
This allows building wireshark-* with a explicitly disabled bluezSupport in an overlay.
Motivation for this change
Build wireshark-cli wothout bluetooth
cc @justin-gerhardt @bjornfor
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)