Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtkcord3: init at 0.0.4 #96941

Closed
wants to merge 1 commit into from
Closed

gtkcord3: init at 0.0.4 #96941

wants to merge 1 commit into from

Conversation

colemickens
Copy link
Member

Motivation for this change

Fixes #96936 by packaging gtkcord3 at version 0.0.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit September 2, 2020 01:25
@colemickens
Copy link
Member Author

It works, marking as ready. Gtkcord3 running on Pinebook Pro:
screenshot-1599011245

@colemickens colemickens marked this pull request as ready for review September 2, 2020 01:49
@jtojnar
Copy link
Contributor

jtojnar commented Sep 2, 2020

See also #91738

@jonringer
Copy link
Contributor

See also #91738

.... there's been ~5000 PRs since late june >.>

@OPNA2608
Copy link
Contributor

OPNA2608 commented Sep 2, 2020

Just wanna point out that the developer has abandoned this project in favour of another.
diamondburned/gtkcord3#84 (comment)
https://github.com/diamondburned/cchat-gtk

@colemickens
Copy link
Member Author

Thanks @OPNA2608 and @jtojnar ! I'm going to go ahead and close this.

@colemickens colemickens closed this Sep 3, 2020
@colemickens
Copy link
Member Author

@OPNA2608 thanks again! cchat-gtk looks very promising! https://media.discordapp.net/attachments/741347063077535874/751153593628753990/screenshot-1599159331.png#w=976;h=805

@jtojnar jtojnar mentioned this pull request Dec 2, 2020
Closed
10 tasks
@colemickens colemickens deleted the gtkcord3 branch December 30, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package request: cchat-gtk/cchat-discord: a chat client with discord backend
4 participants
@colemickens @jtojnar @jonringer @OPNA2608