Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partimage: fix build #99052

Merged
merged 1 commit into from Oct 10, 2020
Merged

partimage: fix build #99052

merged 1 commit into from Oct 10, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 29, 2020

Motivation for this change

ZHF: #97479

The move to glibc 2.30 broke the build of this old package, fortunately debian have a patch to fix it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
partimage: fix build
5983c41 
the move to glibc 2.30 broke the build of this old package, fortunately
debian have a patch to fix it
@risicle risicle mentioned this pull request Oct 10, 2020
Closed
@risicle risicle merged commit 69519cf into NixOS:master Oct 10, 2020
@risicle risicle mentioned this pull request Oct 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdallo ericdallo ericdallo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @ericdallo