Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] roundcube: 1.4.8 -> 1.4.9 #99048

Merged
merged 1 commit into from Sep 29, 2020
Merged

[20.03] roundcube: 1.4.8 -> 1.4.9 #99048

merged 1 commit into from Sep 29, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Sep 28, 2020

https://github.com/roundcube/roundcubemail/releases/tag/1.4.9
(cherry picked from commit f09ae7e)
(cherry picked from commit f8bd03c)

Motivation for this change

Bugfix release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asbachb
Copy link
Contributor Author

asbachb commented Sep 28, 2020

/cc @Ma27

@ofborg ofborg bot requested review from globin, Vskilet and Ma27 September 29, 2020 02:18
@Ma27
Copy link
Member

Ma27 commented Sep 29, 2020

@GrahamcOfBorg test roundcube

@Ma27 Ma27 merged commit 629fe7b into NixOS:release-20.03 Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@Vskilet Vskilet Awaiting requested review from Vskilet

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbachb @Ma27