Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pony-corral: init 0.4.0 #99054

Merged
merged 1 commit into from Sep 29, 2020
Merged

pony-corral: init 0.4.0 #99054

merged 1 commit into from Sep 29, 2020

Conversation

redvers
Copy link
Member

@redvers redvers commented Sep 29, 2020 •
edited

Motivation for this change

Corral is the new package manager for ponylang (ponyc). It is designed to replace pony-stable (which was like a pony stable, not a stable pony - which caused confusion) ;-)

pony-stable is officially deprecated upstream. I've not removed it as I want to provide a window of opportunity for developers to switch their configurations from one to the other.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Thank you in advance for your kind considerations...

ryantm
ryantm approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, waiting for nixpkgs-review now....

@redvers
Copy link
Member Author

redvers commented Sep 29, 2020

@ryantm - I think that's it?
It skipped aarch64 I assume because I didn't tag it as being available for arm.

@ryantm
Copy link
Member

ryantm commented Sep 29, 2020

Result of nixpkgs-review pr 99054 1

1 package built:
- pony-corral

@ryantm ryantm merged commit 3c672fa into NixOS:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@redvers @ryantm