Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oq: fix build #99040

Merged
merged 1 commit into from Oct 10, 2020
Merged

oq: fix build #99040

merged 1 commit into from Oct 10, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 28, 2020

Motivation for this change

ZHF: #97479

A libyaml upgrade broke some overly strict tests in oq. Add a patch from upstream to make these more lenient.

This patch is actually included in the already-released oq 1.1.2, but we can't upgrade to that because it requires crystal 0.35, which we don't seem to have yet.

Also enable for darwin because it WFM macos 10.14.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
oq: fix build
892712e 
this patch is actually included in the already-released oq 1.1.2, but we
can't upgrade to that because it requires crystal 0.35, which we don't
seem to have yet

enable for darwin
@risicle risicle mentioned this pull request Oct 10, 2020
Closed
@markuskowa markuskowa merged commit ae5eda2 into NixOS:master Oct 10, 2020
@risicle risicle mentioned this pull request Oct 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @jonringer @markuskowa