Remove nullptr ExecutionContext early-exits in DOMImplementation #25822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 28, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2432850
branch
from
63e7480
to
82430c5
Compare
They were necessary to prevent crashes at one point, but other refactoring appear to have rendered them unnecessary, and they can cause createDocument/createHTMLDocument to incorrectly return null when they are called on an implementation object from a detached document. Bug: 1128911 Test: dom/nodes/DOMImplementation-createHTMLDocument-with-saved-implementation.html Change-Id: Ia37201a15db195f24e6d3988ee9dddd1d15806c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432850 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#812261}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2432850
branch
from
82430c5
to
3673ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were necessary to prevent crashes at one point, but other
refactoring appear to have rendered them unnecessary, and they can cause
createDocument/createHTMLDocument to incorrectly return null when they
are called on an implementation object from a detached document.
Bug: 1128911
Test: dom/nodes/DOMImplementation-createHTMLDocument-with-saved-implementation.html
Change-Id: Ia37201a15db195f24e6d3988ee9dddd1d15806c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432850
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812261}