sqlitecpp: init 3.1.1 #99063
sqlitecpp: init 3.1.1 #99063
Conversation
jbedo
force-pushed
the
genomicsqlite
branch
5 times, most recently
from
d06ffb5
to
c98d704
Compare
|
Note that there's also an eval error. |
|
I've removed the genomicsqlite component of this as the expression contained a lot of hacky workarounds and upstream wasn't responsive making me think maintenance will be an issue in future. |
| { lib, stdenv, fetchFromGitHub, cmake, sqlite, cppcheck, gtest }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "SQLiteCpp"; |
There was a problem hiding this comment.
pname should match the attribute name.
There was a problem hiding this comment.
@SuperSandro2000 thanks for the review. I noticed you comment this a lot. Is it a convention agreed upon in an RFC somewhere?
There was a problem hiding this comment.
It isn't since some wrappers and other things add something additional to the attr name but thats not the case here and it is only confusing when the package shows up as something else in the searches or env.
| ]; | ||
|
|
||
| meta = with lib; { | ||
| homepage = "http://srombauts.github.com/SQLiteCpp"; |
There was a problem hiding this comment.
That homepage is wrong. The correct is https://srombauts.github.io/SQLiteCpp/
Motivation for this change
Init GenomicSQLite and required SQLiteC++ dependency.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)