Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dnscrypt-proxy2: harden and improve service #99039

Merged
merged 1 commit into from Oct 2, 2020
Merged

nixos/dnscrypt-proxy2: harden and improve service #99039

merged 1 commit into from Oct 2, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

A lot of this is just culted from arch linux's service definition.
The one thing that's unique outside of this is the restartTriggers (I think they're needed?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

It's also important that this just goes for network-online.target and not network.target https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

@worldofpeace
Copy link
Contributor Author

@ofborg test dnscrypt-proxy2

aanderse
aanderse approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@worldofpeace worldofpeace merged commit bd52e7f into NixOS:master Oct 2, 2020
@worldofpeace worldofpeace deleted the dnscrypt-proxy2-harden branch October 2, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @aanderse