Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elm-install and elm-git-install #99033

Closed
wants to merge 1 commit into from
Closed

Add elm-install and elm-git-install #99033

wants to merge 1 commit into from

Conversation

ursi
Copy link
Contributor

@ursi ursi commented Sep 28, 2020

Motivation for this change
Things done

Updated and added nodePackages

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Packages are updated all at once so there's too many to test.

@ofborg ofborg bot requested a review from midchildan September 28, 2020 21:49
@nrdxp nrdxp self-requested a review March 25, 2021 05:30
@stale
Copy link

stale bot commented Sep 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2021
@turboMaCk turboMaCk self-requested a review December 8, 2021 22:33
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 8, 2021
@turboMaCk
Copy link
Member

I'm going to look into this PR

@turboMaCk
Copy link
Member

I'm closing this PR because there was other - newer one opened #101484

@turboMaCk turboMaCk closed this Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrdxp nrdxp nrdxp approved these changes

@midchildan midchildan Awaiting requested review from midchildan

@turboMaCk turboMaCk Awaiting requested review from turboMaCk

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ursi @turboMaCk @nrdxp @ryantm @Janik-Haag