libvirt: 6.3.0 -> 6.6.0 #99043
libvirt: 6.3.0 -> 6.6.0 #99043
Conversation
Also upgrades `python3Packages.libvirt` and patches the `rpcgen` tool from Apple's `developer_cmds` package.
| patches = [ | ||
| ./0001-Fix-build-with-libtirpc.patch |
There was a problem hiding this comment.
Note to reviewers: this patch is in the 6.6.0 release.
| ]; | ||
|
|
||
| nativeBuildInputs = [ makeWrapper pkgconfig docutils rpcsvc-proto ] |
There was a problem hiding this comment.
Note to reviewers: I made including rpcsvc-proto conditional on !isDarwin since it's not needed on that platform.
| buildInputs = [ | ||
| libxml2 gnutls perl python2 readline gettext libtasn1 libgcrypt yajl | ||
| libxslt xhtml1 perlPackages.XMLXPath curl libpcap glib dbus libtirpc |
There was a problem hiding this comment.
Note to reviewers: libtirpc is only needed on Linux so I moved it to the optionals stdenv.isLinux section below.
|
The reason for going to 6.6.0 instead of 6.7.0 (which has been out for nearly a month) is that 6.7 uses meson, I assume? |
There was a problem hiding this comment.
Please:
- Update
http://libvirt.org/tohttps://libvirt.org/andgit://libvirt.org/libvirt.gittohttps://gitlab.com/libvirt/libvirt.git. - See if it works with
NIX_CFLAGS_COMPILE = "-fno-stack-protector";removed. "--with-runstatedir=/run" # TODO: remove when autoconf 1.70 is releasedshould say 2.70.- See [WIP] Improvements to libvirt #85562
Done
The official repo seems to be
I removed it and can confirm it builds without it (I did test this on master and not on staging).
Done. Thanks for the reference. |
Indeed. I have a need for libvirt-6.6.0 because I have a server running that version and I didn't want to go to the trouble figuring out how a build with meson works. I might look into packaging 6.7.0 after this. |
Go to https://libvirt.org/git/ and notice how it is a mirror of https://gitlab.com/libvirt/. Please:
|
That seems to be the official repository now.
|
@TredwellGit there doesn't seem to be a libvirt-6.6.0 release. I just checked and |
SysVirt-6.3.0 should build correctly against libvirt-6.6.0 and also libvirt-6.7.0 since their were no API changes. Also note that because of this there's no SysVirt-6.6.0 release. So this removes the `assert version == pkgs.libvirt.version` protection.
Co-authored-by: Stig P <stig@stig.io>
| @@ -18419,10 +18419,9 @@ let | |||
| SysVirt = buildPerlModule rec { | |||
| pname = "Sys-Virt"; | |||
| version = "6.3.0"; | |||
| src = assert version == pkgs.libvirt.version; fetchgit { | |||
There was a problem hiding this comment.
Note to reviewers: Sys-Virt-6.3.0 builds correctly with libvirt-6.6.0 (and should also build with libvirt-6.7.0) because there were no API changes in those releases. Because of this reason there are no Sys-Virt-6.6.0 or Sys-Virt-6.7.0 releases.
This is #98937 targeted for staging.
Motivation for this change
https://github.com/libvirt/libvirt/blob/master/NEWS.rst#v660-2020-08-02
Things done
Also upgrades
python3Packages.libvirtand patches the
rpcgentool from Apple'sdeveloper_cmdspackage.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)