Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.result: 1.2 -> 1.5 #99042

Merged
merged 1 commit into from Sep 30, 2020
Merged

ocamlPackages.result: 1.2 -> 1.5 #99042

merged 1 commit into from Sep 30, 2020

Conversation

hongchangwu
Copy link
Contributor

@hongchangwu hongchangwu commented Sep 28, 2020 •
edited

Motivation for this change

result 1.5 improves compatibility for OCaml >= 4.08.

References:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: Ubuntu
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hongchangwu
Copy link
Contributor Author

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_02.result ocaml-ng.ocamlPackages_4_08.result

@hongchangwu
Copy link
Contributor Author

cc @vbgl

@vbgl
Copy link
Contributor

vbgl commented Sep 29, 2020

@GrahamcOfBorg build ocamlPackages.tsort

@vbgl
Copy link
Contributor

vbgl commented Sep 29, 2020

The result library is a dependency of hundreds (thousands?) of packages. I suspect that a few of them may break due to the update (like ocaml-version; see a proposed fix: #98950). It would be nice to get a list of things that break and then decide on whether to fix them and how.

@vbgl vbgl marked this pull request as draft September 29, 2020 05:55
@hongchangwu
Copy link
Contributor Author

hongchangwu commented Sep 30, 2020 •
edited

I suspect this commit in opam-repository may give us some good indications.

@hongchangwu
Copy link
Contributor Author

@GrahamcOfBorg build ocamlPackages.alcotest ocamlPackages.cmdliner ocamlPackages.irmin ocamlPackages.irmin_1 ocamlPackages.logs ocamlPackages.ocaml-version ocamlPackages.tsdl

@hongchangwu
Copy link
Contributor Author

@GrahamcOfBorg build ocamlPackages.alcotest ocamlPackages.cmdliner ocamlPackages.irmin ocamlPackages.logs ocamlPackages.tsdl

@vbgl vbgl marked this pull request as ready for review September 30, 2020 21:33
@vbgl
Copy link
Contributor

vbgl commented Sep 30, 2020

@GrahamcOfBorg build acgtk beluga coqPackages.hierarchy-builder dot-merlin-reader eff flow framac fstar jackline liquidsoap ocaml-crunch ocaml-top ocamlformat patdiff satysfi

@vbgl vbgl merged commit 33ed2e9 into NixOS:master Sep 30, 2020
@hongchangwu hongchangwu deleted the result-1.5 branch September 30, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hongchangwu @vbgl