Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coincident edges show as "Naked Edges" #696

Closed
phkahler opened this issue Sep 11, 2020 · 3 comments · Fixed by #697
Closed

Coincident edges show as "Naked Edges" #696

phkahler opened this issue Sep 11, 2020 · 3 comments · Fixed by #697
Labels
mesh

Comments

@phkahler
Copy link
Member

System information

SolveSpace version: 3.0~d8f5a8da

Operating system: Fedora 32

Expected behavior

Make a sketch with 2 rectangles with one point coincident. Extrude. Analyze->Show Naked Edges

There should be no naked edges.

Actual behavior

The coincident edges are shown red and there are 4 naked edges found.

Additional information

You get similar behaviour even if the 2 extrusions are from different sketches as shown here
Coincident_edges

This is similar to the second problem reported in issue #303. It is also loosely related to issue #171.
phkahler added a commit to phkahler/solvespace that referenced this issue Sep 12, 2020
@phkahler
Fix solvespace#696. Account for multiple coincident edges when lookin…
61233f3 
…g for naked edges.
@phkahler phkahler linked a pull request Sep 12, 2020 that will close this issue
Fix #696. Account for multiple coincident edges when looking for nake… #697
Merged
@phkahler
Copy link
Member Author

My recent PR to fix this causes the following model to show zero naked edges at default CT settings. I never figured out why this sketch has any bad edges, or if it's actually misreporting them. Either way it doesn't make sense that the fix for this issue would affect it.
gear90.zip

@phkahler
Copy link
Member Author

The gear90.slvs is still having issues, so I don't think this fix is hiding anything. Everything else I've looked at seems fine too.

phkahler added a commit that referenced this issue Sep 14, 2020
@phkahler
Fix #696. Account for multiple coincident edges when looking for nake…
e74185b 
…d edges.
@ruevs
Copy link
Member

ruevs commented Oct 15, 2020

@phkahler tag this "mesh" please.

@phkahler phkahler added the mesh label Oct 15, 2020
@ruevs ruevs mentioned this issue Oct 15, 2020
Open
@phkahler phkahler mentioned this issue Jun 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mesh
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #696. Account for multiple coincident edges when looking for nake… phkahler/solvespace
2 participants
@phkahler @ruevs