pythonPackages.pysnow: fix build & tests #97716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Sep 10, 2020
Comment on lines
20
to
25
| # for the actual source. the github source is in painful poetry format. | ||
| (fetchPypi { | ||
| inherit pname version; | ||
| sha256 = "5df61091470e48b5b3a6ea75637f69d3aacae20041487ea457a9a0e3093fba8c"; | ||
| }) | ||
| # for the tests - important because we make some dependency version subsitutions |
There was a problem hiding this comment.
you should be able to just use:
format = "pyproject";
and it should be able to build from source fine
There was a problem hiding this comment.
oh thats what pyproject is for...
There was a problem hiding this comment.
ah so it does work that way, but it has the side effect of disabling it for py27.
There was a problem hiding this comment.
I think that's fine, python2 has been EOL for 9 months now
risicle
force-pushed
the
ris-pysnow-fix
branch
from
fcec088
to
9592a9e
Compare
|
ok still works, linux & macos. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF: #97479
Ok so I do something slightly unusual here.
Because I make some requirements-version substitutions I feel it's important we have the tests running. The tests aren't included in the pypi tarball. Usually this would make me switch to the github archive for the source, but being a poetry project, it's not in a ready-to-go format. So I fetch both the pypi tarball and the github archive, from which I extract the tests.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)