Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cassandra-driver: disable python2.7 as upstream dropped support #97760

Closed
wants to merge 1 commit into from

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 11, 2020

Motivation for this change

cassandra-driver dropped support for python 2.7, so we should disable this package
ZHF: #97479
cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor

Why do you say that upstream dropped support for python 2.7? I don't see that: https://github.com/datastax/python-driver/

The driver supports Python 2.7, 3.4, 3.5, 3.6, 3.7 and 3.8.

@drewrisinger
Copy link
Contributor

Title should also be pythonPackages.cassandra-driver: ...

@freezeboy
Copy link
Contributor Author

Oops I took the PIP warning for a cassandra error message instead of a problem with geomet, I will try fix it

@freezeboy freezeboy closed this Sep 11, 2020
@freezeboy freezeboy deleted the fix-cassandra-driver branch September 23, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants