Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anytree: disable python2.7 as it requires enum (from python3.4+) #97761

Closed
wants to merge 1 commit into from
Closed

anytree: disable python2.7 as it requires enum (from python3.4+) #97761

wants to merge 1 commit into from

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 11, 2020 •
edited

Motivation for this change

code requires the enum module which was introduced in python 3.4, so python2 is no more supported
ZHF: #97479
@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor

Looking at this package, only the tests require enum, so we should be able to ignore those files on python2.7: https://github.com/c0fec0de/anytree/search?q=enum&unscoped_q=enum

Regardless, should use pythonOlder or isPy3k vs the whole python as a dependency.

@freezeboy
Copy link
Contributor Author

Is it safe to keep a program without tests ?

@freezeboy
Copy link
Contributor Author

Ok I give up I cannot disable the tests for python 2.7, I don't understand all the loops between graphviz and anytree ... it takes ages to compile and always fail, I let the official maintainer who hopefully knows better what it happening

@freezeboy freezeboy closed this Sep 11, 2020
@drewrisinger drewrisinger mentioned this pull request Sep 12, 2020
Merged
10 tasks
drewrisinger added a commit to drewrisinger/nixpkgs that referenced this pull request Sep 12, 2020
@drewrisinger
python27Packages.anytree: fix build
1d86636 
Tests fail on python2.7 b/c the tests use enums (python 3.4+).
Follow-on from NixOS#97761.
Converts tests to use pytestCheckHook for easier test disabling.
@freezeboy freezeboy deleted the fix-anytree branch September 23, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @drewrisinger