New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.parse: 1.16.0 -> 1.18.0, python-docx: run behave tests #97737
Conversation
Previously the problematic "behave" dependency was not even used at checkPhase.
This looks like its a timing-based test, which are always trouble - perhaps we should try and skip these tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Diff LGTM
- Commits LGTM
- Confirm nix-review results from author:
https://github.com/NixOS/nixpkgs/pull/97737
2 packages failed to build:
python38Packages.pytest-bdd terraform-compliance
18 packages built:
nrfutil python27Packages.parse python27Packages.parse-type python27Packages.pyparser python27Packages.pytest-bdd python37Packages.behave python37Packages.parse python37Packages.parse-type python37Packages.pyparser python37Packages.pytest-bdd python37Packages.python-docx python37Packages.radish-bdd python38Packages.behave python38Packages.parse python38Packages.parse-type python38Packages.pyparser python38Packages.python-docx python38Packages.radish-bdd
@risicle I tried several times building both Probably we could ping someone maintaining nixpkgs on darwin to continue investigating? In the meantime, could you please check that changing
|
I simply think I've got slower computers than you (maybe try building on a heavily loaded machine), and as I say, timing-based tests are just trouble sooner or later. It's not too much of a loss disabling just |
You can disable only that test if using checkInputs = [ pytestCheckHook ... ];
disabledTests = lib.optionals stdenv.isDarwin [ "test_step_decorator_async_run_until_complete" ]; |
Thanks, I added the change. I'd just prefer to fix the test, at least by increasing the timeout, but skipping it on darwin is fine too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Minor point in diff still: redundant
pytest
- Commits LGTM
- Builds via
nix-review
: Failed packages fail onmaster
https://github.com/NixOS/nixpkgs/pull/97737
2 packages failed to build:
python38Packages.pytest-bdd terraform-compliance
18 packages built:
nrfutil python27Packages.parse python27Packages.parse-type python27Packages.pyparser python27Packages.pytest-bdd python37Packages.behave python37Packages.parse python37Packages.parse-type python37Packages.pyparser python37Packages.pytest-bdd python37Packages.python-docx python37Packages.radish-bdd python38Packages.behave python38Packages.parse python38Packages.parse-type python38Packages.pyparser python38Packages.python-docx python38Packages.radish-bdd
Timing-based test is flaky on Darwin: NixOS#97737 (comment)
sorry @maxxk that this turned out to be such a ..... pain of a PR but thanks for sticking through it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/97737
3 packages failed to build:
python37Packages.pytest-bdd python38Packages.pytest-bdd terraform-compliance
17 packages built:
nrfutil python27Packages.parse python27Packages.parse-type python27Packages.pyparser python27Packages.pytest-bdd python37Packages.behave python37Packages.parse python37Packages.parse-type python37Packages.pyparser python37Packages.python-docx python37Packages.radish-bdd python38Packages.behave python38Packages.parse python38Packages.parse-type python38Packages.pyparser python38Packages.python-docx python38Packages.radish-bdd
Timing-based test is flaky on Darwin: NixOS#97737 (comment) (cherry picked from commit 0f34c4e)
Motivation for this change
Fix
behave
which was broken from previousparse
update (seenixpkgs-review
from #95690; behave/behave#862).ZHF: #97479
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)nixpkgs-review:
Failed packages also fail on master.