Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joplin-desktop: 1.0.241 -> 1.0.245 #97774

Merged
merged 1 commit into from Sep 12, 2020
Merged

Conversation

CheariX
Copy link
Contributor

@CheariX CheariX commented Sep 11, 2020

Motivation for this change

Update joplin-desktop to latest version.

Since 1.0.241, sync targets needs to be upgraded.
If anyone uses a recent Android Version, this upgrade (>241) is necessary.

Things done

Update version number & sha256

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested including remote upgrade.

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@ajs124 ajs124 merged commit b036f00 into NixOS:master Sep 12, 2020
@CheariX CheariX deleted the joplin-desktop-1.0.245 branch September 14, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants