Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnetCorePackages.sdk_3_1: 3.1.102 -> 3.1.402 #97803

Merged
merged 2 commits into from Sep 23, 2020
Merged

dotnetCorePackages.sdk_3_1: 3.1.102 -> 3.1.402 #97803

merged 2 commits into from Sep 23, 2020

Conversation

JamieMagee
Copy link
Member

Motivation for this change

Security patch for .NET released earlier this week

Supersedes #92659

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@felschr
Copy link
Member

felschr commented Sep 16, 2020

nixpkgs-review results:

4 packages failed to build:
osu-lazer python-language-server ryujinx wasabibackend

2 packages built:
dotnet-sdk_3 jetbrains.rider

@JamieMagee
Copy link
Member Author

@felschr I pushed the required changes to the dependent packages.

felschr
felschr approved these changes Sep 19, 2020
View reviewed changes
Copy link
Member

@felschr felschr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
  • all depending packages build
Possible improvements

You might want to use a more specific commit message, e.g. dotnetCorePackages.sdk_3_1: fix dependent packages.
Otherwise it looks good to me.

@JamieMagee
Copy link
Member Author

You might want to use a more specific commit message, e.g. dotnetCorePackages.sdk_3_1: fix dependent packages.
Otherwise it looks good to me.

Thanks. I'll force push an updated commit to this branch (if that's allowed)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/231

@felschr
Copy link
Member

felschr commented Sep 19, 2020

Yes, I'd assume this falls under https://nixos.org/manual/nixpkgs/stable/#submitting-changes-hotfixing-pull-requests.

@felschr
Copy link
Member

felschr commented Sep 22, 2020

ping

@JamieMagee
Copy link
Member Author

@felschr Updated the commit message

@AndersonTorres AndersonTorres merged commit c7bc218 into NixOS:master Sep 23, 2020
@felschr
Copy link
Member

felschr commented Sep 23, 2020

@JamieMagee Thanks for the contribution! The dotnet packages have been out of date for quite a while :)

@JamieMagee JamieMagee deleted the dotnet-sdk-3.1 branch September 23, 2020 18:08
@IvarWithoutBones IvarWithoutBones mentioned this pull request Oct 8, 2020
Closed
10 tasks
@mausch mausch mentioned this pull request Oct 18, 2020
Closed
10 tasks
@felschr felschr mentioned this pull request Feb 16, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felschr felschr felschr approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JamieMagee @felschr @nixos-discourse @AndersonTorres @Janik-Haag