Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2Packages.cx_Freeze: remove #97763

Merged
merged 1 commit into from Sep 12, 2020
Merged

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 11, 2020

Motivation for this change

package don't support python 2
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 package removed:
python2.7-cx_Freeze (†6.2)

@drewrisinger
Copy link
Contributor

For future reference, PR titles should start with the top-level attribute of how they're referenced. For this, e.g. python27Packages.cx_freeze: disable

@freezeboy freezeboy changed the title cx_Freeze: disable python2.7 python2Packages.cx_Freeze: remove Sep 11, 2020
@teto teto merged commit 1be0767 into NixOS:master Sep 12, 2020
@teto
Copy link
Member

teto commented Sep 12, 2020

@freezeboy thanks for the help on ZHF. You had to change the commit message but I could do it from GH's UI so that's fine.

@freezeboy freezeboy deleted the disable-py2-cx_Freeze branch September 13, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants