Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.dependency-injector: add missing dependencies #97765

Merged
merged 1 commit into from Sep 13, 2020
Merged

python2Packages.dependency-injector: add missing dependencies #97765

merged 1 commit into from Sep 13, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 11, 2020 •
edited

Motivation for this change

Tests were missing flask and pyyaml
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Gerschtli September 11, 2020 13:05
@doronbehar
Copy link
Contributor

Her as well, could you prefix the commit with pythonPackages.dependency-injector: .

@freezeboy freezeboy changed the title dependency-injector: add missing dependencies python2Packages.dependency-injector: add missing dependencies Sep 11, 2020
@risicle
Copy link
Contributor

risicle commented Sep 13, 2020

@ofborg build python2Packages.dependency-injector python3Packages.dependency-injector

@risicle
Copy link
Contributor

risicle commented Sep 13, 2020

Also, please prefix the commit message with pythonPackages, not just the PR name.

@risicle
Copy link
Contributor

risicle commented Sep 13, 2020

WFM macos 10.14, linux x86_64.

@risicle risicle merged commit b3fd422 into NixOS:master Sep 13, 2020
@freezeboy freezeboy deleted the fix-dependency-injector branch September 13, 2020 11:58
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Gerschtli Gerschtli Awaiting requested review from Gerschtli

Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @doronbehar @risicle @jonringer