Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isso: build from master #97717

Merged
merged 1 commit into from Sep 21, 2020
Merged

isso: build from master #97717

merged 1 commit into from Sep 21, 2020

Conversation

Enteee
Copy link
Contributor

@Enteee Enteee commented Sep 10, 2020 •
edited

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC

@NixOS/nixos-release-managers

@ofborg ofborg bot requested a review from fgaz September 11, 2020 01:32
@fgaz
Copy link
Member

fgaz commented Sep 11, 2020

Related/dup: #97435

@fgaz
Copy link
Member

fgaz commented Sep 11, 2020

If the other one is not good I'll take a look at this

@Enteee
Copy link
Contributor Author

Enteee commented Sep 11, 2020

@fgaz : Think for linking #97435. Same as @jonringer , I do also prefer moving to master instead of applying patches.

@Enteee
isso: build from master
ff40f8b 
* The published 0.12.2 version is broken therefore switch to build from
master. Related Issue: isso-comments/isso#617
* cleanup build inputs
* use python3
jonringer
jonringer approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97717 1

1 package built:
  • isso

@jonringer jonringer merged commit 85c0767 into NixOS:master Sep 21, 2020
@Enteee Enteee mentioned this pull request Sep 21, 2020
Closed
10 tasks
@fgaz
Copy link
Member

fgaz commented Nov 9, 2020 •
edited

This wasn't backported to 20.09!

I'm going to do that now, and I guess I'll also upgrade it to stable since we have a release now nevermind, it was just a late 0.12.2 release on github

@fgaz fgaz mentioned this pull request Nov 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@fgaz fgaz Awaiting requested review from fgaz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enteee @fgaz @jonringer