Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-cash: 4.0.14 -> 4.1.0 #97712

Merged
merged 1 commit into from Sep 11, 2020

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Sep 10, 2020

(cherry picked from commit d3958aa)

Motivation for this change

#97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(cherry picked from commit d3958aa)
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97712 1

1 package built:
  • electron-cash

@Lassulus
Copy link
Member

should target release-20.09 not nixos-20.09

@nyanloutre nyanloutre changed the base branch from nixos-20.09 to release-20.09 September 11, 2020 10:57
@nyanloutre
Copy link
Member Author

Yes, sorry

@Lassulus Lassulus merged commit ae8cbb7 into NixOS:release-20.09 Sep 11, 2020
@nyanloutre nyanloutre deleted the maj_electron_cash_20_09 branch September 11, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants