Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] aws-sam-cli: fix version bounds #97741

Merged
merged 1 commit into from Sep 11, 2020
Merged

[20.09] aws-sam-cli: fix version bounds #97741

merged 1 commit into from Sep 11, 2020

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Sep 11, 2020 •
edited

Backports: #97627
ZHF: #97479
cc @NixOS/nixos-release-managers

Motivation for this change

Backport aws-sam-cli fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame endgame changed the title aws-sam-cli: fix version bounds [20.09] aws-sam-cli: fix version bounds Sep 11, 2020
@ofborg ofborg bot requested a review from lo1tuma September 11, 2020 08:14
@worldofpeace
Copy link
Contributor

Could please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes and use cherry-pick -x. And also reference the PR this backports here?

@endgame
aws-sam-cli: fix version bounds
ce2ffef 
(cherry picked from commit 1e67b4a)
@endgame
Copy link
Contributor Author

endgame commented Sep 11, 2020

Sorry. Fixed.

@worldofpeace worldofpeace merged commit e2aba06 into NixOS:release-20.09 Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo1tuma lo1tuma Awaiting requested review from lo1tuma

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@endgame @worldofpeace