[weakref] FinalizationRegistry.prototype.cleanupSome & "maybe" GC interleaved with queueMicrotask, MutationObserver #25496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erleaved with queueMicrotask, MutationObserver
jugglinmike
reviewed
Sep 15, 2020
js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback-queueMicrotask.optional.any.js
Show resolved
Hide resolved
… GC interleaved with queueMicrotask, MutationObserver
|
There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
jugglinmike
requested changes
Sep 18, 2020
js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback-queueMicrotask.optional.any.js
Outdated
Show resolved
Hide resolved
.../gc-has-one-chance-to-call-cleanupCallback-queueMicrotaskMutationObserver.optional.window.js
Outdated
Show resolved
Hide resolved
…"maybe" GC interleaved with queueMicrotask, MutationObserver
jugglinmike
approved these changes
Sep 19, 2020
|
Hello |
rwaldron
deleted the
weakref-finalizationregistry-microtask-interaction-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jugglinmike these are variants of https://github.com/web-platform-tests/wpt/blob/master/js/builtins/weakrefs/gc-has-one-chance-to-call-cleanupCallback.optional.any.js, where the generic
await ticks++;has been replaced with: