Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme-client: build with gcc #97734

Merged
merged 1 commit into from Sep 12, 2020
Merged

Conversation

treed
Copy link
Contributor

@treed treed commented Sep 11, 2020

acme-client fails to build with clang, which breaks the build on darwin.

Motivation for this change

Trying to fix broken builds on Darwin for ZHF.

ZHF: #97479

acme-client has a compilation error:

./compat.h:55:8: error: expected parameter declarator
size_t strlcat(char *, const char *, size_t);

This error goes away when compiling with gcc, so I set the package to use gccStdenv, after looking to see what similar packages did for this sort of issue.

If there's a better way to handle this, I'm open to feedback.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

acme-client fails to build with clang, which breaks the build on darwin.
@doronbehar
Copy link
Contributor

@GrahamcOfBorg build acme-client

@risicle
Copy link
Contributor

risicle commented Sep 12, 2020

WFM macos 10.14, non-nixos linux x86_64.

@risicle risicle merged commit d8a648b into NixOS:master Sep 12, 2020
@treed treed mentioned this pull request Sep 12, 2020
10 tasks
@treed treed deleted the zhf-darwin-acme-client branch September 15, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants