Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0a21d06682e0
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6d4b93323e7f
Choose a head ref
  • 4 commits
  • 1 file changed
  • 3 contributors

Commits on Jun 2, 2020

  1. gotools: update comments regarding gopls 

    The replaced comment was stating some properties about upstream source
code that are no longer the case. The new comment mentions what's the
current situation in regards to the gopls binary.
    @roman
    roman committed Jun 2, 2020

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    jluttine Jaakko Luttinen
    GPG key ID: 7B1CE13152E6B964
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f0c032a View commit details

Commits on Sep 11, 2020

  1. Update pkgs/development/tools/gotools/default.nix 

    Co-authored-by: Roman Volosatovs <rvolosatovs@users.noreply.github.com>
    @doronbehar @rvolosatovs
    doronbehar and rvolosatovs authored Sep 11, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    5c3abcc View commit details

  2. Update pkgs/development/tools/gotools/default.nix

    @doronbehar
    doronbehar authored Sep 11, 2020
    Copy the full SHA
    79e055e View commit details

  3. Merge pull request #89372 from roman/88716/documentation-changes 

    gotools: update comments regarding gopls
    @doronbehar
    doronbehar authored Sep 11, 2020
    Copy the full SHA
    6d4b933 View commit details
Showing with 10 additions and 6 deletions.
  1. +10 −6 pkgs/development/tools/gotools/default.nix
16 changes: 10 additions & 6 deletions pkgs/development/tools/gotools/default.nix
View file
Original file line number Diff line number Diff line change
@@ -11,12 +11,16 @@ buildGoModule rec {
sha256 = "0a8c7j4w784w441j3j3bh640vy1g6g214641qv485wyi0xj49anf";
};

# Build of golang.org/x/tools/gopls fails with:
# can't load package: package golang.org/x/tools/gopls: unknown import path "golang.org/x/tools/gopls": cannot find module providing package golang.org/x/tools/gopls
# That is most probably caused by golang.org/x/tools/gopls containing a separate Go module.
# In order to fix this, we simply remove the module.
# Note that build of golang.org/x/tools/cmd/gopls provides identical binary as golang.org/x/tools/gopls.
# See https://github.com/NixOS/nixpkgs/pull/64335.
# The gopls folder contains a Go submodule which causes a build failure.
# Given that, we can't have the gopls binary be part of the gotools
# derivation.
#
# The attribute "gopls" provides the gopls binary.
#
# Related
#
# * https://github.com/NixOS/nixpkgs/pull/85868
# * https://github.com/NixOS/nixpkgs/issues/88716
postPatch = ''
rm -rf gopls
'';