Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.supervisor: drop glibc-2.31 patch #97724

Merged
merged 1 commit into from Sep 11, 2020
Merged

pythonPackages.supervisor: drop glibc-2.31 patch #97724

merged 1 commit into from Sep 11, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 11, 2020 •
edited

Motivation for this change

The patch does not apply anymore and has become unnecessary.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 11, 2020
@mweinelt mweinelt requested a review from Ma27 September 11, 2020 00:37
@mweinelt
pythonPackages.supervisor: drop glibc-2.31 patch
4607f02 
A fix was integrated into the 4.2.1 release.
@mweinelt mweinelt changed the title supervisor: drop glibc-2.31 patch pythonPackages.supervisor: drop glibc-2.31 patch Sep 11, 2020
@mweinelt
Copy link
Member Author

Result of nixpkgs-review pr 97724 1

3 packages built:
  • python27Packages.supervisor
  • python37Packages.supervisor
  • python38Packages.supervisor

@ofborg ofborg bot requested a review from zimbatm September 11, 2020 02:19
@Ma27 Ma27 merged commit 914148a into NixOS:master Sep 11, 2020
@Ma27
Copy link
Member

Ma27 commented Sep 11, 2020

Thanks! Ported to stable as 8ab64ff.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 11, 2020
@mweinelt mweinelt deleted the supervisor branch September 11, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @Ma27