Skip to content

nixos/victoriametrics: escape newlines in ExecStart #97758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

nixos/victoriametrics: escape newlines in ExecStart #97758

merged 1 commit into from
Sep 11, 2020
+2 −2

Conversation

yorickvP
Copy link
Contributor

#78038 added a victoriametrics module, but all arguments after httpListenAddr were semi-silently ignored, until @zeonin noticed in #96206.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@yorickvP
nixos/victoriametrics: escape newlines in ExecStart

Verified

This commit was signed with the committer’s verified signature.
shlevy Shea Levy
GPG key ID: 5C0BD6957D86FE27
Verified
Learn about vigilant mode
c1bef53 
Fixes NixOS#96206
@yorickvP
Copy link
Contributor Author

@GrahamcOfBorg test victoriametrics

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 11, 2020
@infinisil infinisil merged commit e0759a4 into NixOS:master Sep 11, 2020
@yorickvP yorickvP deleted the patch-3 branch October 1, 2020 09:27
@yorickvP yorickvP mentioned this pull request Oct 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yorickvP @infinisil