Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrum: 4.0.2 -> 4.0.3 #97792

Merged
merged 1 commit into from Sep 12, 2020
Merged

electrum: 4.0.2 -> 4.0.3 #97792

merged 1 commit into from Sep 12, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Sep 11, 2020

Motivation for this change

Version update: https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from np, ehmry and joachifm September 11, 2020 17:57
@ehmry
Copy link
Contributor

ehmry commented Sep 12, 2020

I can build successfully on aarch64, but if I start the binary I get the error

qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, xcb.

fish: “./result/bin/electrum” terminated by signal SIGABRT (Abort)

This is not a new error, but it would be nice to fix with this update.

@ehmry
Copy link
Contributor

ehmry commented Sep 12, 2020

Works for me with the following:

diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 91d9790fca8..3c3094c0a55 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -20134,11 +20134,11 @@ in

   electron-cash = libsForQt514.callPackage ../applications/misc/electron-cash { };

-  electrum = libsForQt514.callPackage ../applications/misc/electrum { };
+  electrum = libsForQt5.callPackage ../applications/misc/electrum { };

   electrum-dash = callPackage ../applications/misc/electrum/dash.nix { };

-  electrum-ltc = libsForQt514.callPackage ../applications/misc/electrum/ltc.nix { };
+  electrum-ltc = libsForQt5.callPackage ../applications/misc/electrum/ltc.nix { };

   elementary-planner = callPackage ../applications/office/elementary-planner { };

@prusnak
Copy link
Member Author

prusnak commented Sep 12, 2020

Updated the PR to fix the Qt issue.

@ofborg ofborg bot requested a review from ehmry September 12, 2020 10:24
@ehmry ehmry merged commit edecced into NixOS:master Sep 12, 2020
@prusnak prusnak deleted the electrum branch September 12, 2020 20:44
@ehmry ehmry mentioned this pull request Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@np np Awaiting requested review from np

@joachifm joachifm Awaiting requested review from joachifm

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @ehmry