Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/plasma5: fix build with hardware.bluetooth.enable after #97456 #97735

Merged
merged 1 commit into from Sep 11, 2020
Merged

nixos/plasma5: fix build with hardware.bluetooth.enable after #97456 #97735

merged 1 commit into from Sep 11, 2020

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Sep 11, 2020

Motivation for this change

Fixes:

undefined variable 'openobex' at <nixpkgs>/nixos/modules/services/x11/desktop-managers/plasma5.nix:308:80

when configuration.nix has hardware.bluetooth.enable = true;.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @ttuegel

@orivej orivej changed the title nixos/plasma5: fix build with hardware.bluetooth.enable = true after #97456 nixos/plasma5: fix build with hardware.bluetooth.enable after #97456 Sep 11, 2020
@ttuegel ttuegel added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 11, 2020
@ttuegel ttuegel merged commit 98754ab into NixOS:master Sep 11, 2020
@ttuegel
Copy link
Member

ttuegel commented Sep 11, 2020

Thanks!

@ttuegel ttuegel mentioned this pull request Sep 11, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 6.topic: qt/kde 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orivej @ttuegel