New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python2Packages.green: remove #97771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Diff LGTM
- Commits LGTM
- Builds via
nix-review
:
1 package removed:
python2.7-green (†3.2.1)
@freezeboy could you please make the commit |
75277c3
to
96acb3a
Compare
@freezeboy note that changing the title here does not change the commit message. I have amended the commit to speed merging up a little. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 package removed:
python2.7-green (†3.2.1)
@freezeboy could you backport this to the 20.03 branch (using |
@freezeboy do you mind targeting a backport for 20.09? :) |
Motivation for this change
Green package no longer support python2
ZHF: #97479
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)