Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2Packages.green: remove #97771

Merged
merged 1 commit into from Sep 13, 2020
Merged

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 11, 2020

Motivation for this change

Green package no longer support python2
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review:
1 package removed:
python2.7-green (†3.2.1)

@doronbehar
Copy link
Contributor

@freezeboy could you please make the commit python2Packages.green: remove?

@freezeboy freezeboy changed the title green: disable python2.7 python2Packages.green: remove Sep 11, 2020
@danieldk
Copy link
Contributor

@freezeboy note that changing the title here does not change the commit message. I have amended the commit to speed merging up a little.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 package removed:
python2.7-green (†3.2.1)

@danieldk danieldk merged commit 4afc26f into NixOS:master Sep 13, 2020
@danieldk
Copy link
Contributor

@freezeboy could you backport this to the 20.03 branch (using git cherry-pick -x <commit sha>) and open a PR?

@freezeboy
Copy link
Contributor Author

@danieldk done in #97895

@freezeboy freezeboy deleted the disable-py2-green branch September 13, 2020 11:59
@jonringer
Copy link
Contributor

@freezeboy do you mind targeting a backport for 20.09? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants