Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sunvox: fix hash mismatch #97742

Merged
merged 1 commit into from Sep 20, 2020
Merged

sunvox: fix hash mismatch #97742

merged 1 commit into from Sep 20, 2020

Conversation

tasmo
Copy link
Contributor

@tasmo tasmo commented Sep 11, 2020 •
edited

Motivation for this change

fixes hash for downloaded zip file

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from puffnfresh September 11, 2020 08:45
stigtsp
stigtsp approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Updated sha256 matches https://github.com/Homebrew/homebrew-cask/blob/3176e7e1f3a802b127773e8dfad180d43893e6e8/Casks/sunvox.rb

Tested OK

stigtsp
stigtsp requested changes Sep 18, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message so it matches https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

Suggestion: sunvox: fix hash mismatch

@tasmo tasmo changed the title sunvox-1.9.5d - new hash for source zip sunvox-1.9.5d: fix hash mismatch Sep 19, 2020
@tasmo tasmo requested a review from stigtsp September 19, 2020 18:47
stigtsp
stigtsp requested changes Sep 20, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls change sunvox-1.9.5d to sunvox so it matches the name of the attribute :)

@tasmo tasmo changed the title sunvox-1.9.5d: fix hash mismatch sunvox: fix hash mismatch Sep 20, 2020
@tasmo tasmo requested a review from stigtsp September 20, 2020 19:54
stigtsp
stigtsp approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@stigtsp stigtsp merged commit 37ab1fe into NixOS:master Sep 20, 2020
@tasmo tasmo deleted the sunvox-1.9.5d branch September 21, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tasmo @stigtsp