Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lp_solve: fix build #97757

Merged
merged 1 commit into from Sep 13, 2020
Merged

lp_solve: fix build #97757

merged 1 commit into from Sep 13, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 11, 2020 •
edited

Motivation for this change

temporary builds are no more in nested folders
ZHF: #97479
cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from grwlf September 11, 2020 11:03
@ajs124
Copy link
Member

ajs124 commented Sep 11, 2020

cc @NixOS/nixos-release-managers as pinging teams doesn't seem to work if you're not part of one

@freezeboy freezeboy changed the title lp_solve: fix build python2Packages.lp_solve: fix build Sep 11, 2020
@risicle
Copy link
Contributor

risicle commented Sep 13, 2020

Perhaps I'm missing something - how is this a pythonPackage?

@freezeboy
Copy link
Contributor Author

Oh yes, i appended a lot of pythonPackages on my prs and i guess i did this one also

@freezeboy freezeboy changed the title python2Packages.lp_solve: fix build lp_solve: fix build Sep 13, 2020
@risicle
Copy link
Contributor

risicle commented Sep 13, 2020

This fails for me on macos 10.14:

mkdir: created directory '/nix/store/99wkygy5033ihndzmgzpdhdg3yxrwcwk-lp_solve-5.5.2.5'
mkdir: created directory '/nix/store/99wkygy5033ihndzmgzpdhdg3yxrwcwk-lp_solve-5.5.2.5/lib'
cp: -r not specified; omitting directory 'bin/ux64'

@freezeboy
Copy link
Contributor Author

replaced with a find call to handle both situations

@jonringer
Copy link
Contributor

@GrahamcOfBorg build lp_solve

@risicle
Copy link
Contributor

risicle commented Sep 13, 2020

WFM now, macos 10.14, linux x86_64.

I note that the shared library fails to actually build on macos, but this looks like it was true beforehand too.

@risicle risicle merged commit 35ca475 into NixOS:master Sep 13, 2020
@freezeboy freezeboy mentioned this pull request Sep 13, 2020
Merged
10 tasks
@freezeboy freezeboy deleted the fix-lp_solve branch September 13, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grwlf grwlf Awaiting requested review from grwlf

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @ajs124 @risicle @jonringer