Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .redist flag for licenses and auto-build all redist packages #97789

Closed
wants to merge 1 commit into from
Closed

Add .redist flag for licenses and auto-build all redist packages #97789

wants to merge 1 commit into from

Conversation

mkg20001
Copy link
Member

…or some licenses

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evanjs
Copy link
Member

evanjs commented Sep 11, 2020

Resolves #83884

@mkg20001
Copy link
Member Author

The required changes for hydra builds are still missing.

nixpkgs.config = {
  allowUnfree = true;
  allowUnfreePredicate = (x: if x ? meta.license.redist then x.meta.license.redist else false);
};

Not sure if I should make an option like allowUnfreeRedistributableOnly = true; that would enable only unfree redist = true packages.

Or make allowRedistibutable = true; which which would enable redist = true packages regardless of license..

@stale
Copy link

stale bot commented Mar 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 16, 2021
@petrosagg petrosagg mentioned this pull request Apr 15, 2021
Open
@kevincox kevincox closed this in 16fb392 Aug 11, 2021
centromere pushed a commit to centromere/nixpkgs that referenced this pull request Aug 11, 2021
@Atemu @centromere
lib.licenses: introduce redistributable attribute
76d8549 
Allows for distinction of licenses that are unfree overall but do grant the
right to redistribute. Defaults to the freeness of the license.

Note: Many unfree but are redistributable licenses aren't marked as such.
I expect that to be fixed in a distributed manner over time.

Closes NixOS#97789
github-actions bot pushed a commit to nix-community/nixpkgs.lib that referenced this pull request Aug 15, 2021
@Atemu
lib.licenses: introduce redistributable attribute
99aa920 
Allows for distinction of licenses that are unfree overall but do grant the
right to redistribute. Defaults to the freeness of the license.

Note: Many unfree but are redistributable licenses aren't marked as such.
I expect that to be fixed in a distributed manner over time.

Closes NixOS/nixpkgs#97789
github-actions bot pushed a commit to nix-community/nixpkgs.lib that referenced this pull request Dec 4, 2022
@Atemu
lib.licenses: introduce redistributable attribute
260ad95 
Allows for distinction of licenses that are unfree overall but do grant the
right to redistribute. Defaults to the freeness of the license.

Note: Many unfree but are redistributable licenses aren't marked as such.
I expect that to be fixed in a distributed manner over time.

Closes NixOS/nixpkgs#97789
github-actions bot pushed a commit to nix-community/nixpkgs.lib that referenced this pull request May 31, 2023
@Atemu
lib.licenses: introduce redistributable attribute
b56f81e 
Allows for distinction of licenses that are unfree overall but do grant the
right to redistribute. Defaults to the freeness of the license.

Note: Many unfree but are redistributable licenses aren't marked as such.
I expect that to be fixed in a distributed manner over time.

Closes NixOS/nixpkgs#97789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais alyssais will be requested when the pull request is marked ready for review alyssais is a code owner

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkg20001 @evanjs