Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] j: fix build on darwin #97749

Merged
merged 1 commit into from Sep 11, 2020
Merged

[20.09] j: fix build on darwin #97749

merged 1 commit into from Sep 11, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Sep 11, 2020

Motivation for this change

backport of #97525

ZHF: #97479

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
[20.09] j: fix build on darwin
efc358e 
(cherry picked from commit fbefec0)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 11, 2020
@domenkozar domenkozar merged commit 18f9a65 into NixOS:release-20.09 Sep 11, 2020
@Luflosi Luflosi deleted the backport-j branch September 11, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @domenkozar