Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud: 17.0.6 -> 17.0.9, 18.0.7 -> 18.0.9, 19.0.1 -> 19.0.3 #97751

Closed
wants to merge 3 commits into from
Closed

nextcloud: 17.0.6 -> 17.0.9, 18.0.7 -> 18.0.9, 19.0.1 -> 19.0.3 #97751

wants to merge 3 commits into from

Conversation

puppe
Copy link
Contributor

@puppe puppe commented Sep 11, 2020 •
edited

Motivation for this change

I have updated the Nextcloud packages to the most recent releases (changelog).

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions

  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

Edit: checklist

@puppe
Copy link
Contributor Author

puppe commented Sep 11, 2020 •
edited

I don't know how this is supposed to work. Should I backport these changes to 20.03 and 20.09 myself and post two more pull requests?

Edit: BTW, can anyone explain to me how I can run the tests ?

Edit: Nevermind.

@Ma27
Copy link
Member

Ma27 commented Sep 11, 2020

Heh, I actually had those changes locally, but didn't file a PR yet :)
I'm actually in favor of removing nextcloud17 and nextcloud18 as both versions will get EOLed during the lifetime of 20.09: https://docs.nextcloud.com/server/19/admin_manual/release_schedule.html

@Ma27
Copy link
Member

Ma27 commented Sep 11, 2020

@puppe if that's okay for you, I'd cherry-pick your nextcloud19 bump to my branch and take care of the removal of the other packages, ok? :)

@puppe
Copy link
Contributor Author

puppe commented Sep 12, 2020 •
edited

@Ma27 Sure, that's okay. Thanks. :)

@Ma27
Copy link
Member

Ma27 commented Sep 12, 2020

Nice. Will take care of it on monday.

@Ma27 Ma27 self-assigned this Sep 12, 2020
@Ma27 Ma27 added this to the 20.09 milestone Sep 12, 2020
@ajs124
Copy link
Member

ajs124 commented Sep 16, 2020

@Ma27 any updates on this?

@Ma27
Copy link
Member

Ma27 commented Sep 17, 2020

Not yet :)

This was referenced Sep 20, 2020
Merged
Merged
@Ma27
Copy link
Member

Ma27 commented Sep 20, 2020

@Ma27 Ma27 closed this in #98333 Sep 27, 2020
@azirila
Copy link

azirila commented Oct 6, 2020 •
edited

hello everyone, I have a question we currently have nextcloud version 17.0.9 and I would like to update to version 18.0.9 for this I was able to update to higher version via web console but now no one knows why I cannot use this version update to the higher version ie, 18.0.9
nextcloud

@Ma27
Copy link
Member

Ma27 commented Oct 6, 2020

You should be able to do this by declaring services.nextcloud.package = pkgs.nextcloud18; in your NixOS config.

@azirila
Copy link

azirila commented Oct 6, 2020 via email

@Ma27
Copy link
Member

Ma27 commented Oct 6, 2020

So you're running the Nix package on Ubuntu?

@azirila
Copy link

azirila commented Oct 6, 2020 via email •
edited

@azirila
Copy link

azirila commented Oct 6, 2020

nixos
i dont have nixos just ubuntu

@Ma27
Copy link
Member

Ma27 commented Oct 6, 2020 •
edited

Are you sure that this is related to our repository then and not an Ubuntu bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@globin globin Awaiting requested review from globin

@schneefux schneefux Awaiting requested review from schneefux

@fpletz fpletz Awaiting requested review from fpletz

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees

@Ma27 Ma27

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@puppe @Ma27 @ajs124 @azirila @bachp