Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-iscsi: install systemd files #97793

Merged
merged 1 commit into from Nov 4, 2020
Merged

open-iscsi: install systemd files #97793

merged 1 commit into from Nov 4, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Sep 11, 2020

Motivation for this change

So they can be used with systemd.packages.

As draft, because I need to properly test this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zaninime
Copy link
Contributor

LGTM. Let me know if you manage to use it successfully and I can do a final test as well.

@ajs124 ajs124 marked this pull request as ready for review October 8, 2020 15:56
@ajs124
Copy link
Member Author

ajs124 commented Oct 8, 2020

I also have a module using this now, if anyone is interested in that.

@zaninime
Copy link
Contributor

@cleverca22 could you also please have a look?

@ajs124 if you're willing to publish your module, please open a separate PR for that and link it to this one by mentioning it. Other reviewers will also be involved.

@ajs124 ajs124 mentioned this pull request Oct 18, 2020
Closed
10 tasks
@ajs124
Copy link
Member Author

ajs124 commented Oct 30, 2020

ping @zaninime

@zaninime
Copy link
Contributor

zaninime commented Nov 3, 2020

I don't have merge rights. @zimbatm, could you please have a look? We interacted before on some other PR.

@zaninime zaninime requested a review from zimbatm November 3, 2020 23:06
@ajs124
Copy link
Member Author

ajs124 commented Nov 4, 2020

I don't have merge rights. @zimbatm, could you please have a look? We interacted before on some other PR.

I can merge this, although I prefer having approval of at least one of the package's maintainers. So if you give your 👍 @zaninime, I'll merge.

zimbatm
zimbatm approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimbatm zimbatm merged commit c30745e into NixOS:master Nov 4, 2020
@ajs124 ajs124 deleted the feat/openiscsi/systemd branch November 4, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

@cleverca22 cleverca22 Awaiting requested review from cleverca22

@zaninime zaninime Awaiting requested review from zaninime

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @zaninime @zimbatm