Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jackmix, jackmix_jack1: fix build, add alsaLib dependency #97753

Merged
merged 1 commit into from Sep 11, 2020
Merged

jackmix, jackmix_jack1: fix build, add alsaLib dependency #97753

merged 1 commit into from Sep 11, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 11, 2020 •
edited

Motivation for this change

Add alsaLib to fix build
ZHF: #97479
cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy changed the title jackmix, jackmix_jack1: fix build, add alsaLib dependency python2Packages.jackmix, python2Packages.jackmix_jack1: fix build, add alsaLib dependency Sep 11, 2020
@freezeboy freezeboy changed the title python2Packages.jackmix, python2Packages.jackmix_jack1: fix build, add alsaLib dependency jackmix, jackmix_jack1: fix build, add alsaLib dependency Sep 11, 2020
@risicle
Copy link
Contributor

risicle commented Sep 11, 2020

WFM, non-nixos linux x86_64

@risicle risicle merged commit 8029886 into NixOS:master Sep 11, 2020
@freezeboy freezeboy deleted the fix-jackmix branch September 11, 2020 21:25
@freezeboy freezeboy mentioned this pull request Sep 12, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @risicle